Re: [Xen-devel] [PATCH] x86: don't allow Dom0 to map MSI-X table writably

[Keir Fraser <keir.xen@xxxxxxxxx>]

On 14/02/2012 14:54, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> With the traditional qemu tree fixed to not use PROT_WRITE anymore in
> the mmap() call for this region, and with the upstream qemu tree not
> being capable of handling passthrough, yet, there's no need to treat
> Dom specially here anymore.
> 
> This continues to leave unaddressed the case where PV guests map the
> MSI-X table page(s) before setting up the first MSI-X interrupt (see
> the original c/s 22182:68cc3c514a0a description for options).
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Keir Fraser <keir@xxxxxxx>

> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -869,7 +869,7 @@ get_page_from_l1e(
>              return -EINVAL;
>          }
>  
> -        if ( !(l1f & _PAGE_RW) || IS_PRIV(pg_owner) ||
> +        if ( !(l1f & _PAGE_RW) ||
>               !rangeset_contains_singleton(mmio_ro_ranges, mfn) )
>              return 0;
>          dprintk(XENLOG_G_WARNING,
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel