Re: [Xen-devel] [PATCH 22 of 23] libxl: idl: generate KeyedUnion key member as part of the KeyedUnion

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-02-13 at 17:08 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH 22 of 23] libxl: idl: generate 
> KeyedUnion key member as part of the KeyedUnion"):
> > libxl: idl: generate KeyedUnion key member as part of the KeyedUnion
> > 
> > Rather than specifying it twice in the IDL.
> ...        else:
> > diff -r 0751a69b3ef2 -r ba485f9fce31 tools/libxl/libxl_types.idl
> > --- a/tools/libxl/libxl_types.idl   Mon Feb 13 16:27:34 2012 +0000
> > +++ b/tools/libxl/libxl_types.idl   Mon Feb 13 16:27:34 2012 +0000
> > @@ -214,7 +214,6 @@ libxl_domain_build_info = Struct("domain
> >      ("shadow_memkb",    MemKB),
> >      ("disable_migrate", libxl_defbool),
> >      ("cpuid",           libxl_cpuid_policy_list),
> > -    ("type",            libxl_domain_type),
> >      
> >      ("device_model_version", libxl_device_model_version),
> 
> If I'm not mistaken, an effect of this is to move the type field
> around in the C structure - ie, it's not ABI compatible.  This is OK
> at this stage, I think, but I just wanted to check that that was what
> you meant.

It was.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel