Re: [Xen-devel] [PATCH V6 11/11] pci: Do not check if a bus exist in pci_parse_devaddr.

["Michael S. Tsirkin" <mst@xxxxxxxxxx>]

On Mon, Feb 13, 2012 at 12:20:13PM +0000, Anthony PERARD wrote:
> Actually, pci_parse_devaddr checks if the dom/bus of the PCI address exist. 
> But
> this should be the jobs of a caller. In fact, the two callers of this function
> will try to retrieve the PCIBus related to the devaddr and return an error if
> they cannot.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

I agree. It's a good patch. And this will help address the bridges.
Want me to queue this?

> ---
>  hw/pci.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/hw/pci.c b/hw/pci.c
> index ebb5de9..da7cf79 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -529,10 +529,6 @@ int pci_parse_devaddr(const char *addr, int *domp, int 
> *busp,
>      if (*e)
>       return -1;
>  
> -    /* Note: QEMU doesn't implement domains other than 0 */
> -    if (!pci_find_bus(pci_find_root_bus(dom), bus))
> -     return -1;
> -
>      *domp = dom;
>      *busp = bus;
>      *slotp = slot;
> -- 
> Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel