Re: [Xen-devel] [PATCH v3 1/5] hvmloader: Only compile 32bitbios_support.c when rombios is enabled

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sat, 2012-02-11 at 20:39 +0000, Julian Pidancet wrote:
> 32bitbios_support.c only contains code specific to rombios, and should
> not be built-in when building hvmloader for SeaBIOS only (as for
> rombios.c).
> 
> Signed-off-by: Julian Pidancet <julian.pidancet@xxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

I acked this patch last time too -- please collate Acks in repostings
where no substantial change has been made to a patch so reviewers can
save the effort.

Ian.

> ---
>  tools/firmware/hvmloader/Makefile |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/firmware/hvmloader/Makefile 
> b/tools/firmware/hvmloader/Makefile
> index 41a4369..e82146a 100644
> --- a/tools/firmware/hvmloader/Makefile
> +++ b/tools/firmware/hvmloader/Makefile
> @@ -29,7 +29,7 @@ LOADADDR = 0x100000
>  CFLAGS += $(CFLAGS_xeninclude)
>  
>  OBJS  = hvmloader.o mp_tables.o util.o smbios.o 
> -OBJS += 32bitbios_support.o smp.o cacheattr.o xenbus.o
> +OBJS += smp.o cacheattr.o xenbus.o
>  OBJS += e820.o pci.o pir.o ctype.o
>  ifeq ($(debug),y)
>  OBJS += tests.o
> @@ -39,7 +39,7 @@ CIRRUSVGA_DEBUG ?= n
>  
>  ROMBIOS_DIR := ../rombios
>  ifneq ($(ROMBIOS_DIR),)
> -OBJS += rombios.o
> +OBJS += 32bitbios_support.o rombios.o
>  CFLAGS += -DENABLE_ROMBIOS
>  ROMBIOS_ROM := $(ROMBIOS_DIR)/BIOS-bochs-latest
>  endif



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel