Re: [Xen-devel] [PATCH] arm: define domain_pirq_to_irq

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 9 Feb 2012, Ian Campbell wrote:
> On Thu, 2012-02-09 at 15:18 +0000, Stefano Stabellini wrote:
> > On Thu, 9 Feb 2012, Ian Campbell wrote:
> > > # HG changeset patch
> > > # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > # Date 1328798112 0
> > > # Node ID abd72cc240fa3d643541d435f3cb72b75c8a5977
> > > # Parent  18b9ea53c8ac0e2d6aee68dd50a50c0b08a01a1e
> > > arm: define domain_pirq_to_irq
> > > 
> > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > > 
> > > diff -r 18b9ea53c8ac -r abd72cc240fa xen/include/asm-arm/irq.h
> > > --- a/xen/include/asm-arm/irq.h   Thu Feb 09 11:33:30 2012 +0000
> > > +++ b/xen/include/asm-arm/irq.h   Thu Feb 09 14:35:12 2012 +0000
> > > @@ -11,6 +11,7 @@ typedef struct {
> > >  
> > >  struct arch_pirq
> > >  {
> > > +    int irq;
> > >  };
> > >  
> > >  struct irq_cfg {
> > > @@ -19,6 +20,8 @@ struct irq_cfg {
> > >  
> > >  void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq);
> > >  
> > > +#define domain_pirq_to_irq(d, pirq) pirq_field(d, pirq, arch.irq)
> > > +
> > >  #endif /* _ASM_HW_IRQ_H */
> > >  /*
> > >   * Local variables:
> > > 
> > 
> > At the moment we don't have a reason for having pirq != irq so we could
> > just return irq, like ia64 does.
> 
> Good idea.
> 
> > Otherwise I expect that we would need code to set arch.irq = pirq that
> > at the moment we don't have.
> 
> Yes.
> 
> 8<-----------------------------------
> 
> # HG changeset patch
> # User Ian Campbell <ian.campbell@xxxxxxxxxx>
> # Date 1328800759 0
> # Node ID daa129cac86315bad066f4c358bd02817985a8df
> # Parent  18b9ea53c8ac0e2d6aee68dd50a50c0b08a01a1e
> arm: define domain_pirq_to_irq
> 
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

ack

> diff -r 18b9ea53c8ac -r daa129cac863 xen/include/asm-arm/irq.h
> --- a/xen/include/asm-arm/irq.h       Thu Feb 09 11:33:30 2012 +0000
> +++ b/xen/include/asm-arm/irq.h       Thu Feb 09 15:19:19 2012 +0000
> @@ -19,6 +19,8 @@ struct irq_cfg {
>  
>  void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq);
>  
> +#define domain_pirq_to_irq(d, pirq) (pirq)
> +
>  #endif /* _ASM_HW_IRQ_H */
>  /*
>   * Local variables:
> 
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel