Re: [Xen-devel] [PATCH 2 of 5] Clean up locking now that p2m lockups are fully synchronized

["Andres Lagar-Cavilla" <andres@xxxxxxxxxxxxxxxx>]

> On Wed, 2012-02-01 at 19:56 +0000, Andres Lagar-Cavilla wrote:
>> @@ -1445,7 +1449,7 @@ p2m_get_nestedp2m(struct vcpu *v, uint64
>>              nestedp2m_unlock(d);
>>              return p2m;
>>          }
>> -        p2m_unlock(p2m);
>> +        gfn_unlock(p2m, gfn, 0);
>>      }
>
> It looks like maybe you forgot to change the corresponding p2m_lock() to
> gfn_lock(), here in p2m.c:p2m_get_nestedp2m()?

Good catch! (evil macro argument squashing!)
Thanks
Andres

>
> Other than that, I think the PoD stuff looks fine.  So regarding PoD
> stuff:
> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
>
>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel