Re: [Xen-devel] [PATCH 4 of 6] libxl: support suspend_cancel in domain_resume

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-02-01 at 19:30 +0000, Shriram Rajagopalan wrote:
> On 2012-02-01, at 8:02 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> 
> > On Wed, 2012-02-01 at 15:48 +0000, Pasi Kärkkäinen wrote:
> >> On Wed, Feb 01, 2012 at 10:53:54AM +0000, Ian Campbell wrote:
> >>> On Tue, 2012-01-31 at 17:52 +0000, Shriram Rajagopalan wrote:
> >>>> As for guests supporting this fast suspend, almost all guests (pv/hvm
> >>>> linux/windows) do support suspend_cancel. IIRC, I think some very old
> >>>> kernels didnt have this ability.
> >>> 
> >>> Slight aside, does Remus work with mainline Linux domU kernels? Users
> >>> seem to be under under that impression.
> >>> 
> >>> I know you had some patches at one point but I a) don't remember if they
> >>> went in and b) don't remember if they were sufficient.
> >>> 
> >> 
> >> http://wiki.xen.org/wiki/Remus
> >> "Linux 2.6.39.2 and later upstream kernel.org versions are now supported 
> >> as PV domU kernels"
> > 
> > Great, someone was suggesting on list that this wasn't the case. Must
> > dig out that mail and respond.
> > 
> > Ian.
> > 
> > 
> 
> I added the comments on top of the second version of the patch series.
> Please let me know if it looks okay.
> 
> I will be spinning out a V3 anyway, since Stefano has removed  qmp_migrate.
> But this patch would remain the same, if it's current form is okay.

If you are respinning anyway then putting a comment in the header rather
than the implementation would be better since that is where users of the
library will be looking for it.

The comment from xc_resume.c which you copied explains the two modes but
doesn't actually say how the fast parameter relates to them. A better
comment to lift would be the description of @fast from xenctrl.h:

        "fast [means] use cooperative resume (guest must support this)"

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel