[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] qemu-dm: unregister_iomem() broken?

On Tue, 31 Jan 2012, Jan Beulich wrote:
> This function (introduced quite a long time ago in
> e7911109f4321e9ba0cc56a253b653600aa46bea - "disable qemu PCI
> devices in HVM domains") appears to be completely broken, causing
> the regression reported in
> http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=1805 (due to
> the newly added caller of it in
> 56d7747a3cf811910c4cf865e1ebcb8b82502005 - "qemu: clean up
> MSI-X table handling"). As it's unclear how the function can ever
> have fulfilled its purpose, and as I'm not seeing the log message
> resulting from it being called on the sole original call path with SLE11
> guests, I'd like to ask you or someone else at Citrix with access to a
> suitable guest to double check that the below patch doesn't break it.

Any upstream Linux kernel with PVHVM would work as a testcase.
Just make sure you have CONFIG_XEN_PVHVM=y and the appropriate frontends
in the kernel config.

> Once verified that it fixes the problem at hand *and* doesn't break
> what it was supposed to be sued for originally, I'll do a formal
> submission.

I have run a smoke test, here is the interesting part of the logs
without this patch:

region type 0 at [f3000000,f3020000).
squash iomem [f3020000, f3021000).
region type 1 at [c100,c140).

and now with this patch:

region type 0 at [f3000000,f3020000).
squash iomem [f3000000, f3020000).
region type 1 at [c100,c140).

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.