Re: [Xen-devel] XEN 4.1.3-rc1 bug, spinlock acquired twice

[Paulian Bogdan Marinca <paulian@xxxxxxxxxxx>]

>>
>> I attach my kernel config (btw is actually a 3.0.6 kernel not 3.2.1)
>>
>> I will try to apply your patch against XEN.
>
> In that case it is a matter of protecting Xen against misbehaving
> guests, so I would rather have the patch below than try to handle the
> case correctly.
>
>
>
>> > diff --git a/xen/arch/x86/physdev.c b/xen/arch/x86/physdev.c
>> > index df92cc7..7d89ed6 100644
>> > --- a/xen/arch/x86/physdev.c
>> > +++ b/xen/arch/x86/physdev.c
>> > @@ -93,6 +93,11 @@ int physdev_map_pirq(domid_t domid, int type, int 
>> > *index, int *pirq_p,
>> >
>> >     if ( domid == DOMID_SELF && is_hvm_domain(d) )
>> >     {
>> > +        if ( !is_hvm_pv_evtchn_domain(d) )
>> > +        {
>> > +            ret = -EINVAL;
>> > +            goto free_domain;
>> > +        }
>> >         ret = physdev_hvm_map_pirq(d, type, index, pirq_p);
>> >         goto free_domain;
>> >     }
>>

I tested the patch and yes, it prevents Xen being locked up.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel