Re: [Xen-devel] [PATCH 13/24] mini-os: fix list.h include guard name

[Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>]

On 01/27/2012 08:06 AM, Ian Campbell wrote:
> On Thu, 2012-01-26 at 19:45 +0000, Daniel De Graaf wrote:
>> The symbol _LINUX_LIST_H collides with other header files.
> 
> Hrm mini-os is supposed to have been BSD licensed since
> 19712:7a215fae6f1f and that symbol name is *rather* suspicious.
> 
> The thread associated with that commit[0] suggests that everything GPL
> had been rewritten but I suspect that due to the lack of GPL header this
> file was missed.
> 
> This effectively means that any work combined with mini-os was GPL
> rather than BSD as might reasonably have been expected. I believe
> everything in-tree which we link with mini-os (the stubdom/ tree) is GPL
> or GPL-compatible but this has laid rather a nasty trap for anyone else
> using mini-os and I think we should fix it ASAP. Below is a patch which
> switches to using the same BSD sys/queue.h list macros as we use in
> libxl.

I'm assuming you are going to push this patch in prior to my series, so I'll
try to rebase on top of it. Currently, the Makefile changes seem to be broken:

make[3]: *** No rule to make target 
`/home/daniel/git/xen/tools/libxl/../../tools/include/xen-external/bsd-sys-queue-h-seddery',
 needed by `_libxl_list.h'.  Stop.

> 
> Presumably you came across another file which used _LINUX_LIST_H which
> clashed? Out of interest what was it?
> 
> Ian.

This symbol is used as the include guard in tools/xenstore/list.h.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel