[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [xen-unstable bisection] complete build-amd64

On Thu, Jan 26, Ian Jackson wrote:

> cc1: warnings being treated as errors
> xc_mem_paging.c: In function 'xc_mem_paging_load':
> xc_mem_paging.c:90: error: statement with no effect
> make[3]: *** [xc_mem_paging.o] Error 1
> make[3]: Leaving directory 
> `/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64'
> make[2]: *** [build] Error 2
> make[2]: Leaving directory 
> `/home/osstest/build.11617.build-amd64/xen-unstable/stubdom/libxc-x86_64'
> make[1]: *** [libxc-x86_64/libxenctrl.a] Error 2
> make[1]: *** Waiting for unfinished jobs....

As Andrew Morton put it once: "We code in C, not in cpp".

extras/mini-os/include/posix/sys/mman.h:19:#define munlock(addr, len) 
((void)(addr), (void)(len), 0)

As such, that define should be "static inline munlock(const void *addr, size_t 
len) { return 0; }".
And now that I actually look at that header, mlock should be changed as
well. All this "(void)fn()" mess is really confusing.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.