Re: [Xen-devel] [xen-unstable test] 11574: tolerable FAIL

["Andres Lagar-Cavilla" <andres@xxxxxxxxxxxxxxxx>]

> Hi,
>
> At 16:00 +0000 on 24 Jan (1327420844), Ian Jackson wrote:
>> Ian Jackson writes ("Re: [xen-unstable test] 11574: tolerable FAIL"):
>> > This is a host-specific, but deterministic, failure.
>>
>> Improve handling of nested page faults
>>
>> Add checks for access type. Be less reliant on implicit semantics.
>>
>> Signed-off-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
>> Acked-by: Tim Deegan <tim@xxxxxxx>
>> Committed-by: Tim Deegan <tim@xxxxxxx>
>
> Hmm, Didn't have to pull on that thread too hard to find it's not tied
> to anything.  The access_* arguments to hvm_hap_nested_page_fault()
> aren't plumbed in on AMD:
>
>     ret = hvm_hap_nested_page_fault(gpa, 0, ~0ul, 0, 0, 0, 0);
>
> so gating behaviour on them is not going to work so well.  Sorry about
> that - I should definitely have caught this.  (But Andres, did you test
> this, or any of your mm work, on AMD?)

Phew, thanks Tim. FWIW:
Acked-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>

And, no, we haven't tested on AMD, because we depend critically on the
support that has been built into EPT for paging/mem_access.

Andres
>
> The attached patch ought to fix it.  Smoke-tested but I won't have
> good enough access to my test machines to check Windows installs before
> Thursday.
>
> Cheers,
>
> Tim.
>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel