[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [xen-unstable test] 11574: tolerable FAIL

  • To: "Tim Deegan" <tim@xxxxxxx>
  • From: "Andres Lagar-Cavilla" <andres@xxxxxxxxxxxxxxxx>
  • Date: Tue, 24 Jan 2012 09:23:33 -0800
  • Cc: Adin Scannell <adin@xxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 24 Jan 2012 17:23:55 +0000
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=lagarcavilla.org; h=message-id :in-reply-to:references:date:subject:from:to:cc:reply-to :mime-version:content-type:content-transfer-encoding; q=dns; s= lagarcavilla.org; b=eENl91budv6T4WjOOvsvTKjWiNRQ3cisxYSWuIkBAYrU up6S0RVV3XoUyA8CBqvc4z7prUbTXzxtoZFAt26aA1uJW3dkjKrsyI0O41UdTdPq Yc62DBet17+ISdZSmmwrnJ3x4IUcaI/Yw+IMhWMPE8Xo+AN4991Rk3TddwTeSe8=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

> Hi,
> At 16:00 +0000 on 24 Jan (1327420844), Ian Jackson wrote:
>> Ian Jackson writes ("Re: [xen-unstable test] 11574: tolerable FAIL"):
>> > This is a host-specific, but deterministic, failure.
>> Improve handling of nested page faults
>> Add checks for access type. Be less reliant on implicit semantics.
>> Signed-off-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
>> Acked-by: Tim Deegan <tim@xxxxxxx>
>> Committed-by: Tim Deegan <tim@xxxxxxx>
> Hmm, Didn't have to pull on that thread too hard to find it's not tied
> to anything.  The access_* arguments to hvm_hap_nested_page_fault()
> aren't plumbed in on AMD:
>     ret = hvm_hap_nested_page_fault(gpa, 0, ~0ul, 0, 0, 0, 0);
> so gating behaviour on them is not going to work so well.  Sorry about
> that - I should definitely have caught this.  (But Andres, did you test
> this, or any of your mm work, on AMD?)

Phew, thanks Tim. FWIW:
Acked-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>

And, no, we haven't tested on AMD, because we depend critically on the
support that has been built into EPT for paging/mem_access.

> The attached patch ought to fix it.  Smoke-tested but I won't have
> good enough access to my test machines to check Windows installs before
> Thursday.
> Cheers,
> Tim.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.