Re: [Xen-devel] [PATCH 11/21] mini-os: make frontends and xenbus optional

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-01-23 at 16:21 +0000, Daniel De Graaf wrote:
> On 01/23/2012 07:51 AM, Ian Campbell wrote:
> > Better to define init_FOOfront for each of these and have it be a nop in
> > the ifndef case and avoid the ifdefs in the code itself.
> > 
> > Likewise the ifdef's in the teardown. Ideally the actual meat in the
> > ifdef cases would be moved into the files you aren't compiling (e.g.
> > netfront_thread goes into netfront.c) and only the stubs remain in some
> > header somewhere.
> > 
> > Ian.
> > 
> 
> The majority of kernel.c seems to be test code intended to be overridden
> by the application; see the comment above app_main:
> 
> /* This should be overridden by the application we are linked against. */
> __attribute__((weak)) int app_main(start_info_t *si)
> 
> As such, maybe all of this code should be moved out of kernel.c and into
> test.c, and have a better noop app_main in kernel.c.

That sounds reasonable to me.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel