Re: [Xen-devel] [PATCH] x86/vMSI: miscellaneous fixes

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.01.12 at 17:39, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> On 20/01/12 16:33, Jan Beulich wrote:
>> @@ -291,9 +285,22 @@ static int msixtbl_write(struct vcpu *v,
>>      if ( !virt )
>>          goto out;
>>  
>> +    /* Do not allow the mask bit to be changed. */
>> +#if 0 /* XXX
> 
> You appear to still have some debugging in this patch.

No - that's why the comment is there. I wanted to keep the unused
code to make clear what ought to be taking place here.

Jan

>> +       * As the mask bit is the only defined bit in the word, and as the
>> +       * host MSI-X code doesn't preserve the other bits anyway, doing
>> +       * this is pointless. So for now just discard the write (also
>> +       * saving us from having to determine the matching irq_desc).
>> +       */




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel