Re: [Xen-devel] [PATCH v5 05/25] Introduce clear_user and clear_guest

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.01.12 at 16:20, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> 
>>> wrote:
> On Fri, 20 Jan 2012, Stefano Stabellini wrote:
>> On Thu, 19 Jan 2012, Jan Beulich wrote:
>> > >>> On 19.01.12 at 17:46, "Jan Beulich" <JBeulich@xxxxxxxx> wrote:
>> > > As I wanted to use the clear_guest stuff you add here for some
>> > > cleanup/latent bug fix in x86's paging code, I pulled this patch into
>> > > my local tree. Unfortunately the ia64 bits don't build, as you omitted
>> > > the #define-s at the top of the file you took the code from.
>> > 
>> > Further, the file you put this in is one that shouldn't be modified. The
>> > correct way is to simply pull in Linux'es clear_user.S (see below).
>> > 
>> 
>> Yes, I think that you are correct.
> 
> Can I add your signed-off-by to this patch?
> I have pulled your changes in and removed my changes to
> xen/arch/ia64/linux/memcpy_mck.S.

S-O-B would seem too much (I didn't really write any code here, and
didn't touch the non-ia64 bits at all). An Acked-By would be okay, or
else you'd have to split the ia64 bits from the rest (and they could
really go in independently).

Btw., what's the take on getting at least the common code cleanup/
adjustment patches committed? I had recommended taking them
already after you had posted v5 (but now I'm glad they didn't get
committed without this ia64 issue addressed).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel