Re: [Xen-devel] [PATCH] xen: kill __u*/__s* integer types

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.01.12 at 16:16, Christoph Egger <Christoph.Egger@xxxxxxx> wrote:
> On 01/20/12 15:57, Jan Beulich wrote:
>>>>> On 20.01.12 at 15:50, Christoph Egger<Christoph.Egger@xxxxxxx>  wrote:
>>> On 01/20/12 15:36, Jan Beulich wrote:
>>>>>>> On 20.01.12 at 15:05, Christoph Egger<Christoph.Egger@xxxxxxx>   wrote:
>>>>> Kill __u*/__s* integer types and use c99 integer types instead.
>>>>> Cleanup<asm-x86/types.h>
>>>>
>>>> Was this build-tested for ia64?
>>>
>>> No. I don't have such a machine.
>>
>> And you don't need to. You can just use a cross tool chain.
>>
>>> Can you do that, please?
>>
>> I'm trying to avoid having to do (a perhaps massive) cleanup after
>> a patch like this.
>>
>> If you can't/don't want to do the cross build (given that the ARM
>> bits are sort of ready to be committed, it might be a good idea to
>> check against those bits too), then please adjust the patch so
>> that it won't break the build for arches you don't test.
> 
> 
> I just figured this out:
> 
> <xen/types.h> includes <asm/types.h> which doesn't exist on ia64.
> So I guess ia64 doesn't build anyway...

Which is obviously not the case. There are multiple places where you
need to look for such a header on ia64 - in this case, it's in
xen/include/asm-ia64/linux-xen/asm.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel