Re: [Xen-devel] [PATCH 08 of 12] x86/mm: use RCU in mem sharing audit list, eliminate global lock completely

[Tim Deegan <tim@xxxxxxx>]

At 21:56 -0500 on 15 Jan (1326664588), Andres Lagar-Cavilla wrote:
>  xen/arch/x86/mm/mem_sharing.c     |  94 
> +++++++++++++++++---------------------
>  xen/arch/x86/mm/mm-locks.h        |  18 -------
>  xen/include/asm-x86/mem_sharing.h |   1 +
>  3 files changed, 43 insertions(+), 70 deletions(-)
> 
> 
> Signed-off-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>

Acked-by: Tim Deegan <tim@xxxxxxx>

I suspect you'll get errors because this

> @@ -215,11 +215,13 @@ static int mem_sharing_audit(void)
>      unsigned long count_expected;
>      unsigned long count_found = 0;
>      struct list_head *ae;
> +    DECLARE_PG_LOCK_DATA(pld);
>  
> -    ASSERT(shr_locked_by_me());
>      count_expected = atomic_read(&nr_shared_mfns);
>  

is no longer protected by a lock, but since they're not fatal, that's
OK. 

Tim.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel