Re: [Xen-devel] [PATCH 14 of 32 RFC] libxl: HVM device configuration info build_info->u.hvm

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-01-16 at 16:29 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[Xen-devel] [PATCH 14 of 32 RFC] libxl: HVM device 
> configu> libxl: HVM device configuration info build_info->u.hvm
> 
> I'm not sure I agree with this change.

There were several things that I wasn't sure about the placement of. I
just knew that device_model_info was wrong ;-)

>   In general our model is that
> devices might be provided via HVM or PV interfaces but the config
> doesn't distinguish.
> 
> Eg, if we implement some kind of pvusb, aren't we just going to have
> to move it back ?

On the one hand I agree.

On the other hand these particular two USB options are very thin shims
over the equivalent qemu options and do not contain anything like the
necessary richness to allow them to describe a device in the detail
needed to be a first class thing in the IDL. I suspect that if/when we
have PVUSB we will gain libxl_device_usb as a thing which is completely
orthogonal to these two.

I think a similar argument applies to the audio option?

Boot, Serial and the platform PCI options are pretty HVM specific I
think.

While we are at it -- do you have any thoughts on how per-arch options
should be handled? I was thinking of adding the possibility in the IDL
to tag a field with a list of architectures?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel