Re: [Xen-devel] [PATCH RFC V4 4/5] kvm : pv-ticketlocks support for linux guests running on KVM hypervisor

[Raghavendra K T <raghavendra.kt@xxxxxxxxxxxxxxxxxx>]

On 01/16/2012 08:42 AM, Alexander Graf wrote:
> On 14.01.2012, at 19:26, Raghavendra K T wrote:
>
> > Extends Linux guest running on KVM hypervisor to support pv-ticketlocks.
> >
> > During smp_boot_cpus  paravirtualied KVM guest detects if the hypervisor has
> > required feature (KVM_FEATURE_PVLOCK_KICK) to support pv-ticketlocks. If so,
> > support for pv-ticketlocks is registered via pv_lock_ops.
> >
> > Use KVM_HC_KICK_CPU hypercall to wakeup waiting/halted vcpu.
> >
> > Signed-off-by: Srivatsa Vaddagiri<vatsa@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Suzuki Poulose<suzuki@xxxxxxxxxx>
> > Signed-off-by: Raghavendra K T<raghavendra.kt@xxxxxxxxxxxxxxxxxx>
> > ---
> > diff --git a/arch/x86/include/asm/kvm_para.h b/arch/x86/include/asm/kvm_para.h
> > index 7a94987..cf5327c 100644
> > --- a/arch/x86/include/asm/kvm_para.h
> > +++ b/arch/x86/include/asm/kvm_para.h
> > @@ -195,10 +195,20 @@ void kvm_async_pf_task_wait(u32 token);
> > void kvm_async_pf_task_wake(u32 token);
[...]
> > +}
> > +#endif /* CONFIG_PARAVIRT_SPINLOCKS */
> > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> > index c7b05fc..4d7a950 100644
> > --- a/arch/x86/kvm/x86.c
> > +++ b/arch/x86/kvm/x86.c
> This patch is mixing host and guest code. Please split those up.
Agree. The host code should have gone to patch 2.

> Alex
>
> > @@ -5754,8 +5754,9 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel