Re: [Xen-devel] [RFC PATCH 2/6] netback: add module unload function.

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Fri, 2012-01-13 at 17:57 +0000, David Vrabel wrote:
> On 13/01/12 16:59, Wei Liu wrote:
> > Enables users to unload netback module.
> [...]
> > diff --git a/drivers/net/xen-netback/netback.c 
> > b/drivers/net/xen-netback/netback.c
> > index 26af7b7..dd10c0d 100644
> > --- a/drivers/net/xen-netback/netback.c
> > +++ b/drivers/net/xen-netback/netback.c
> > @@ -1653,5 +1653,19 @@ failed_init:
> >  
> >  module_init(netback_init);
> >  
> > +static void __exit netback_exit(void)
> > +{
> > +   int i;
> > +   for (i = 0; i < xen_netbk_group_nr; i++) {
> > +           struct xen_netbk *netbk = &xen_netbk[i];
> > +           del_timer(&netbk->net_timer);
> 
> This needs to be del_timer_sync().
> 
> > +           kthread_stop(netbk->task);
> > +   }
> > +   vfree(xen_netbk);
> > +   page_pool_destroy();
> > +   xenvif_xenbus_exit();
> > +}

Both fixed.

Thanks
Wei.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel