Re: [Xen-devel] [PATCH 11/18] xenstored: add NO_SOCKETS compilation option

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-01-11 at 17:21 +0000, Daniel De Graaf wrote:
> @@ -308,7 +310,10 @@ static void set_fd(int fd, fd_set *set, int *max)
>  }
>  
>  
> -static int initialize_set(fd_set *inset, fd_set *outset, int sock,
> int ro_sock,
> +static int initialize_set(fd_set *inset, fd_set *outset,
> +#ifndef NO_SOCKETS
> +                         int sock, int ro_sock,
> +#endif
>                           struct timeval **ptimeout)
>  {
>         static struct timeval zero_timeout = { 0 }; 

Rather than removing the argument why not simply accept -1 as a "no
sock" value and DTWT with that, this ought to reduce the amount of
ifdeffery substantially

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel