Re: [Xen-devel] [PATCH 06/18] lib{xc, xl}: Seed grant tables with xenstore and console grants

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-01-11 at 17:21 +0000, Daniel De Graaf wrote:
> From: Alex Zeffertt <alex.zeffertt@xxxxxxxxxxxxx>
> 
> This patch claims one reserved grant entry for the console and another
> for the xenstore. It modifies the builder to fill in the grant table
> entries for the console and the xenstore.
> 
> This has not been tested with any kind of migration.
> 
[...]
> diff --git a/tools/libxc/xc_domain_restore.c b/tools/libxc/xc_domain_restore.c
> index 3fda6f8..23619da 100644
> --- a/tools/libxc/xc_domain_restore.c
> +++ b/tools/libxc/xc_domain_restore.c
> @@ -2018,6 +2018,15 @@ int xc_domain_restore(xc_interface *xch, int io_fd, 
> uint32_t dom,
>          memcpy(ctx->live_p2m, ctx->p2m, dinfo->p2m_size * sizeof(xen_pfn_t));
>      munmap(ctx->live_p2m, P2M_FL_ENTRIES * PAGE_SIZE);
> 
> +/* TODO don't hardcode zero here */
> +    rc = xc_dom_gnttab_seed(xch, dom,
> +                            *console_mfn, *store_mfn, 0, 0);

Presumably this TODO is the source of the comment in the changelog WRT
migration.

Does it Just Work or is there a legitimate TODO item here?

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel