Re: [Xen-devel] [PATCH RFC v2] build: add autoconf to replace custom checks in tools/check

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.01.12 at 21:37, Roger Pau Monne <roger.pau@xxxxxxxxxxxxx> wrote:
> --- a/README  Thu Jan 05 17:25:23 2012 +0000
> +++ b/README  Mon Jan 09 21:33:52 2012 +0100
> @@ -41,6 +41,7 @@ provided by your OS distributor:
>      * GCC v3.4 or later
>      * GNU Make
>      * GNU Binutils
> +    * GNU Autoconf v2.67 or later

I think Ian had asked this already, but I also think that I didn't see
an answer: Is this relatively new version really a requirement. Not
even SLE11 SP2, which hasn't shipped yet, has this new an
autoconf package. And I would hope to continue to be able to
build on SLE10 SP4, which only has 2.59, without having to
manually build newer packages...

>      * Development install of zlib (e.g., zlib-dev)
>      * Development install of Python v2.3 or later (e.g., python-dev)
>      * Development install of curses (e.g., libncurses-dev)
> @@ -87,9 +88,21 @@ 2. cd to xen-unstable (or whatever you s
>  3. For the very first build, or if you want to destroy build trees,
>     perform the following steps:
>  
> +   If you are building Xen from a repository (git or mercurial) you
> +   must run:
> +
> +    # ./autogen.sh
> +
> +   Before executing ./configure (this step can be ommited when
> +   building from a distribution package).
> +
> +    # ./configure

Can these two steps be automated (i.e. the need to run either
be determined by the absence of some file(s), and them being
invoked from the top level Makefile)?

>      # make world
>      # make install
>  
> +   If you want, you can run ./configure --help to see the list of
> +   options available options when building and installing Xen.
> +
>     This will create and install onto the local machine. It will build
>     the xen binary (xen.gz), the tools and the documentation.
>  
> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
> +++ b/autogen.sh      Mon Jan 09 21:33:52 2012 +0100
> @@ -0,0 +1,11 @@
> +#!/bin/sh

Adding -e here ...

> +rm -rf configure
> +cd tools
> +autoheader && autoconf
> +if [ "$?" = "0" ]
> +then

... would eliminate the need for this conditional ...

> +    cd ..
> +    echo "#!/bin/sh" >> configure
> +    echo "cd tools && ./configure \$@" >> configure
> +    chmod +x configure

... and catch failure anywhere here.

> +fi
> --- a/tools/Rules.mk  Thu Jan 05 17:25:23 2012 +0000
> +++ b/tools/Rules.mk  Mon Jan 09 21:33:52 2012 +0100
> @@ -3,6 +3,7 @@
>  # `all' is the default target
>  all:
>  
> +include $(XEN_ROOT)/config/Tools.mk
>  include $(XEN_ROOT)/Config.mk

Wouldn't the order better be the other way around (generic before
subdir specific)?

>  
>  export _INSTALL := $(INSTALL)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel