[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 10/25] arm: bit manipulation, copy and division libraries

On Tue, 10 Jan 2012, Ian Campbell wrote:
> On Mon, 2012-01-09 at 17:59 +0000, stefano.stabellini@xxxxxxxxxxxxx
> wrote:
> > From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> > 
> > Bit manipulation, division and memcpy & friends implementations for the
> > ARM architecture, shamelessly taken from Linux.
> When I initially imported these I did so with the minimal changes
> possible to integrate the in the Xen tree so as to aid future merges of
> this code from Linux.
> This meant there was quite a lot of ifdef'd code (in particular for
> previous ARM architectures via __LINUX_ARM_ARCH__) but I think that is a
> price worth paying to keep these files somewhat in sync. I used a pretty
> ugly "#if 1 /* __LINUX_ARM_ARCH__ >= 5 */" construct to minimise changes
> but perhaps it would be better to simply define __LINUX_ARM_ARCH__
> appropriately within the lib subdirectory?

I am not a great fan of manually sync'ed source files, however I
understand your concerns. At that point we might have to move
__aeabi_uldivmod and __aeabi_ldivmod to a different location, if we
really want to keep these files identical.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.