Re: [Xen-devel] [PATCH] tools: fix ipxe version issue in Makefile

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-01-06 at 07:44 +0000, Ren, Yongjie wrote:
> Hi All,
> 
> The ipxe git commit version changed, but its release version should
> still stay at v1.0.0

Doesn't this effectively undo the change in 24455:94180a5a0c7c since the
$T rules first tries to wget $(IPXE_TARBALL_URL) before cloning the git
tree? Therefore with this change it is going to find and clone v1.0
instead of using the git tag.

> 
>  
> 
> Signed-off-by: Yongjie Ren <yongjie.ren@xxxxxxxxx>
> 
> ------
> 
>  
> 
> diff -r 4086e4811547 tools/firmware/etherboot/Makefile
> 
> --- a/tools/firmware/etherboot/Makefile Thu Jan 05 17:25:23 2012 +0000
> 
> +++ b/tools/firmware/etherboot/Makefile Fri Jan 06 14:30:54 2012 +0800
> 
> @@ -12,7 +12,9 @@
> 
>  
> 
> IPXE_GIT_TAG := 9a93db3f0947484e30e753bbd61a10b17336e20e
> 
>  
> 
> -IPXE_TARBALL_URL :=
> $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_GIT_TAG).tar.gz
> 
> +IPXE_VERSION := v1.0.0
> 
> +
> 
> +IPXE_TARBALL_URL :=
> $(XEN_EXTFILES_URL)/ipxe-git-$(IPXE_VERSION).tar.gz
> 
>  
> 
> D=ipxe
> 
> T=ipxe.tar.gz
> 
>  
> 
> Best Regards,
> 
>      Yongjie Ren  (Jay)
> 
>  
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel