[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] qemu-xen: fix sequence of operations in pt_msix_init()

On Tue, 3 Jan 2012, Jan Beulich wrote:
> Checking the return value of mmap() must be done before adjusting the
> value, otherwise failure may not be detected.
> Closing the file handle, on the other hand, can be done before checking
> the return value.
> Finally, printing the errno value without knowing whether the previous
> function actually failed is bogus (and superfluous since a subsequent
> message prints the strerror() representaton anyway).
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.