Re: [Xen-devel] Stubdom build problem in 4.1.2 but not in xen-unstable

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.12.11 at 18:03, Roger Pau MonnÃ<roger.pau@xxxxxxxxxxxxx> wrote:
> Hello,
> 
> I've found the following problem while building Xen 4.1.2 stubdoms:
> 
> gcc -DCONFIG_QEMU -mno-red-zone -O1 -fno-omit-frame-pointer
> -fno-optimize-sibling-calls  -m64 -mno-red-zone -fno-reorder-blocks
> -fno-asynchronous-unwind-tables -m64 -g -fno-strict-aliasing
> -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value
> -Wdeclaration-after-statement -Wno-unused-but-set-variable  -nopie
> -fno-stack-protector -fno-exceptions -fno-builtin -Wall -Werror
> -Wredundant-decls -Wno-format -Wno-redundant-decls
> -fno-stack-protector -fgnu89-inline -Wstrict-prototypes
> -Wnested-externs -Wpointer-arith -Winline -g -DGNT_DEBUG
> -DGNTMAP_DEBUG -D__INSIDE_MINIOS__ -m64 -mno-red-zone
> -fno-reorder-blocks -fno-asynchronous-unwind-tables -Os
> -fomit-frame-pointer -isystem
> /home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/../extras/mini-os/includ
> e
> -D__MINIOS__ -DHAVE_LIBC -isystem
> /home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/../extras/mini-os/includ
> e/posix
> -isystem 
> /home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/../tools/xenstore
>  -isystem 
> /home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/../extras/mini-os/inc
> lude/x86
> -isystem 
> /home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/../extras/mini-os/inc
> lude/x86/x86_64
> -U __linux__ -U __FreeBSD__ -U __sun__ -nostdinc -isystem
> /home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/../extras/mini-os/includ
> e/posix
> -isystem 
> /home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/cross-root-x86_64/x8
> 6_64-xen-elf/include
> -isystem /usr/lib/gcc/x86_64-alpine-linux-uclibc/4.6.2/include
> -isystem 
> /home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/lwip-x86_64/src/inclu
> de
> -isystem 
> /home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/lwip-x86_64/src/inclu
> de/ipv4
> -I/home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/include
> -I/home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/../xen/include
> -isystem 
> /home/royger/aports/testing/xen/src/xen-4.1.2/extras/mini-os/../../extras/m
> ini-os/include
> -D__MINIOS__ -DHAVE_LIBC -isystem
> /home/royger/aports/testing/xen/src/xen-4.1.2/extras/mini-os/../../extras/mini-
> os/include/posix
> -isystem 
> /home/royger/aports/testing/xen/src/xen-4.1.2/extras/mini-os/../../tools/xe
> nstore
> -DHAVE_LWIP -isystem
> /home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/lwip-x86_64/src/include
> -isystem 
> /home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/lwip-x86_64/src/inclu
> de/ipv4
> -D__XEN_INTERFACE_VERSION__=0x00030205  -isystem
> /home/royger/aports/testing/xen/src/xen-4.1.2/extras/mini-os/../../extras/mini-
> os/include/x86
> -isystem 
> /home/royger/aports/testing/xen/src/xen-4.1.2/extras/mini-os/../../extras/m
> ini-os/include/x86/x86_64
> -c console/xencons_ring.c -o
> /home/royger/aports/testing/xen/src/xen-4.1.2/stubdom/mini-os-x86_64-ioemu/conso
> le/xencons_ring.o
> console/xencons_ring.c: In function 'xencons_ring_send_no_notify':
> console/xencons_ring.c:26:41: error: inlining failed in call to
> 'xencons_interface': call is unlikely and code size would grow
> [-Werror=inline]
> console/xencons_ring.c:38:18: error: called from here [-Werror=inline]
> cc1: all warnings being treated as errors
> 
> Although I can build xen-unstable without any problems on the same
> machine. I've been trying to find the patch that solved this on
> unstable, but so far I haven't found it. Anyone know which patch fixed
> it? I would like to have it backported to xen-4.1.

It may well be that there is no such changeset, but the compiler just
decides to evaluate the likelihoods differently. I'm assuming that the
build problem would go away by removing -Winline from
extras/mini-os/minios.mk:DEF_CFLAGS (which is questionable in
conjunction with the -Werror forced there too - a more reasonably
approach would seem to be -Winline -Wno-error=inline, apparently
available since gcc 4.2.x).

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel