Re: [Xen-devel] [PATCH 2 of 3] Re-name xenstore key used to save VM generation ID buffer address

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Ian Jackson [mailto:Ian.Jackson@xxxxxxxxxxxxx]
> Sent: 15 December 2011 16:25
> To: Paul Durrant
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH 2 of 3] Re-name xenstore key used to
> save VM generation ID buffer address
> 
> Paul Durrant writes ("[Xen-devel] [PATCH 2 of 3] Re-name xenstore
> key used to save VM generation ID buffer address"):
> > Re-name xenstore key used to save VM generation ID buffer address.
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> >
> > diff -r a4a569729741 -r 9618ee3b6896
> tools/firmware/hvmloader/acpi/build.c
> > --- a/tools/firmware/hvmloader/acpi/build.c Wed Dec 14 14:34:45
> 2011 +0000
> > +++ b/tools/firmware/hvmloader/acpi/build.c Wed Dec 14 14:34:47
> 2011 +0000
> > @@ -309,7 +309,7 @@ unsigned long new_vm_gid(void)
> >      if ( snprintf(addr, sizeof(addr), "0x%lx", virt_to_phys(buf))
> >           >= sizeof(addr) )
> >          return 0;
> > -    xenstore_write("data/generation-id", addr);
> > +    xenstore_write("hvmloader/generation-id-address", addr);
> 
> Will just making just this change to hvmloader not cause failures
> without the corresponding patch to the toolstack to make that path
> writeable ?
> 

The xenstore-write will fail with EACCES but the failure is ignored so there 
should be no knock-on failure. Nothing consumes the key until the subsequent 
tools patch is applied, at which point the xenstore-write will work because the 
tools will have made the key writable.

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel