Re: [Xen-devel] [PATCH] VM generation ID save/restore and migrate

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Paul Durrant writes ("[Xen-devel] [PATCH] VM generation ID save/restore and 
migrate"):
> VM generation ID save/restore and migrate.
> 
> Add code to track the address of the VM generation id buffer across a
> save/restore or migrate and increment it as necessary.
> The address of the buffer is written into xenstore by hvmloader at
> boot time. It must be read from xenstore by the caller of
> xc_domain_save() and then written back again by the caller of
> xc_domain_restore().
...
> +        if ( RDEXACT(fd, &buf->vm_gid_addr, sizeof(uint32_t)) ||
> +             RDEXACT(fd, &buf->vm_gid_addr, sizeof(uint64_t)) )

I'm generally OK with this, but I have two comments.  Firstly
"vm_gid_addr" etc. is a bit opaque and there might be lots of things
called a "g identifier".

Perhaps we could call these variables
  vm_generationid_addr
or something ?

> +    ents[12] = "data/generation-id";

And this xenstore key suggests that the value is the id, not the
address.  I think it should be renamed.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel