Re: [Xen-devel] [xen-unstable test] 10481: regressions - FAIL

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2011-12-13 at 14:48 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [xen-unstable test] 10481: regressions 
> - FAIL"):
> > The choices are (omitting the ia64 only ones):
> > xen/include/public/domctl.h:#define XEN_DOMCTL_SENDTRIGGER_NMI    0
> > xen/include/public/domctl.h:#define XEN_DOMCTL_SENDTRIGGER_POWER  3
> > xen/include/public/domctl.h:#define XEN_DOMCTL_SENDTRIGGER_SLEEP  4
> > 
> > Of those I think POWER is the only appropriate one and we have no
> > control over what it will actually do.
> 
> Right.
> 
> > > At the moment it doesn't work at all without pv drivers.
> 
> I think it would be better for "xl shutdown" to send a power button
> event than to do nothing and print an error message.
> 
> > You can explicitly ask for a power button event with "xl button-press".
> > At a minimum the error message should point to this in preference to
> > destroy.
> 
> That would be a better improvement.

So which do you prefer? An error message pointing to "xl button-press"
or sending the button press?

Ian.

> 
> > You can also send the same event with "xl trigger". Quite why we need
> > two ways to do this I've no idea...
> 
> Hmmm.
> 
> Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel