[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 3 of 8] Tools: Update memshr tool to use new sharing API

To: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 12 Dec 2011 12:14:40 +0000
Cc: "andres@xxxxxxxxxxxxxx" <andres@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Tim \(Xen.org\)" <tim@xxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>, "adin@xxxxxxxxxxxxxx" <adin@xxxxxxxxxxxxxx>
Delivery-date: Mon, 12 Dec 2011 12:18:10 +0000
List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Andres Lagar-Cavilla writes ("[PATCH 3 of 8] Tools: Update memshr tool to use 
new sharing API"):
>  #ifdef MEMSHR
> -       image->memshr_id = memshr_vbd_image_get(file);
> +       image->memshr_id = memshr_vbd_image_get((char *)file);

This case would be unnecessary if memshr_vbd_image_get was
const-correct, which I think would be better.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

References:
- [Xen-devel] [PATCH 0 of 8] Tools: Memory sharing interface updates
  - From: Andres Lagar-Cavilla
- [Xen-devel] [PATCH 3 of 8] Tools: Update memshr tool to use new sharing API
  - From: Andres Lagar-Cavilla

Prev by Date: Re: [Xen-devel] [PATCH 15/18] xenstore: New function xs_path_is_subpath
Next by Date: Re: [Xen-devel] [PATCH 15/15] libxl: New event generation API
Previous by thread: Re: [Xen-devel] [PATCH 3 of 8] Tools: Update memshr tool to use new sharing API
Next by thread: [Xen-devel] [PATCH 4 of 8] Tools: Add a sharing command to xl for information about shared pages
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.