Re: [Xen-devel] [PATCH 14/15] libxl: New API for providing OS events to libxl

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2011-12-09 at 15:44 +0000, Stefano Stabellini wrote:
[...]
> >  tools/libxl/Makefile         |    2 +-
> >  tools/libxl/libxl.c          |   25 ++
> >  tools/libxl/libxl.h          |    6 +
> >  tools/libxl/libxl_event.c    |  711 
> > ++++++++++++++++++++++++++++++++++++++++++
> >  tools/libxl/libxl_event.h    |  199 ++++++++++++
> >  tools/libxl/libxl_internal.h |  216 +++++++++++++-

Please do trim the thousand lines of patch which you aren't commenting
on. Just including the hunk or function you are commenting on is
sufficient for context and snipping appropriately makes makes it far
easier to find the wheat in the chafe.

(this applies to everyone, this is just the latest one to annoy me ;-))

Ian.

[...snip...]


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel