Re: [Xen-devel] [PATCH 08 of 18] Tools: Add a sharing command to xl for information about shared pages

["Andres Lagar-Cavilla" <andres@xxxxxxxxxxxxxxxx>]

> Andres Lagar-Cavilla writes ("[PATCH 08 of 18] Tools: Add a sharing
> command to xl for information about shared pages"):
>> +static void sharing(int totals, const libxl_dominfo *info, int
>> nb_domain)
>> +{
>> +    int i;
>> +
>> +    printf("Name                                        ID   Mem
>> Shared\n");
>> +
>> +    for (i = 0; i < nb_domain; i++) {
>> +        char *domname;
>> +        unsigned shutdown_reason;
>> +        domname = libxl_domid_to_name(ctx, info[i].domid);
>> +        shutdown_reason = info[i].shutdown ? info[i].shutdown_reason :
>> 0;
>> +        printf("%-40s %5d %5lu  %5lu\n",
>> +                domname,
>> +                info[i].domid,
>> +                (unsigned long) (info[i].current_memkb / 1024),
>> +                (unsigned long) (info[i].shared_memkb / 1024));
>> +        free(domname);
>> +    }
>> +
>> +    if (totals)
>> +    {
>> +        /* To be added with a future patch. */
>> +    }
>> +}
>
> Is this analogous to an "xm sharing" command ?
>
> Perhaps we should try to integrate this information in the output of
> "xl list" (although we do have some backward compatibility issues
> there).
>
> Maybe we need to invent "xl llist" or "xl list -v" or something.
I seem to recall that several weeks ago, when Adin first posted this
patch, he was asked to not break xl list compatibility with xm list. Hence
the separate command.

Will also try to add doc to xl.pod.1

Thanks
Andres
>
> Ian.
>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel