Re: [Xen-devel] [PATCH V2 1/2] xen/granttable: Support sub-page grants

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2011-12-09 at 07:45 +0000, annie li wrote:
> 
> On 2011-12-9 13:19, annie li wrote:
> > Hi Paul,
> >
> >>>> #define get_free_entry()    get_free_entries(1)
> > Is this necessary? Maybe you defined this to keep consistence with 
> > put_free_entry(ref)?
> > But other functions such as gnttab_grant_foreign_transfer and 
> > gnttab_grant_foreign_access all call get_free_entries(1). Maybe it is 
> > better to keep initial get_free_entries(1) code?
> Another approach is doing those work in a separate patch -- changing 
> get_free_entries to get_free_entry in following 4 functions:

I think you shouldn't get too bogged down in get_free_entry() vs
get_free_entries(1) for the purposes of this patch series.

Ian.

> gnttab_grant_foreign_access
> gnttab_grant_foreign_access_subpage
> gnttab_grant_foreign_access_trans
> gnttab_grant_foreign_transfer
> 
> Thanks
> Annie



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel