Re: [Xen-devel] [PATCH 01 of 18] x86/mm: Code style fixes in mem_sharing.c

[Tim Deegan <tim@xxxxxxx>]

At 08:16 -0800 on 08 Dec (1323332187), Andres Lagar-Cavilla wrote:
> > At 02:47 -0500 on 08 Dec (1323312436), Andres Lagar-Cavilla wrote:
> >> Harmless patch, with no functional changes, only code style issues.
> >>
> >> Signed-off-by: Andres Lagar-Cavilla <andres@xxxxxxxxxxxxxxxx>
> >
> > ...
> >
> >> -    return -2;
> >> +    return 0;
> >
> > Ahem. :)
> >
> > Tim.
> Borderline, I'll admit. I can play down the tone of the header -- nothing
> is really harmless :)
> 
> The function will still produce the same outputs on the same inputs, with
> cleaner code.

Ah, so it will.  I'll apply this, but in future I'd like long patches
that do tedious whitespace fixups to _just_ have whitespace fixups. 
It reduces the chance of nasty surprises (and the chance that I'll have
to read a long patch of tedious whitespace fixups more than once!)

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel