Re: [Xen-devel] [PATCH RFC 02/25] A collection of fixes to Xen common files

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.12.11 at 12:20, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
wrote:
> On Wed, 7 Dec 2011, Jan Beulich wrote:
>> >>> On 06.12.11 at 19:19, <stefano.stabellini@xxxxxxxxxxxxx> wrote:
>> > +extern char _srodata[], _erodata[];
>> 
>> While I realize that this isn't currently the case on e.g. the respective
>> .text symbols, if you introduce new once, please add const to the
>> declarations *at least* when the section contents really are read only
>> (in many cases doing so even for writable sections is likely appropriate
>> too).
> 
> OK
> 
> 
>> > +#define is_kernel_rodata(p) ({                  \
>> > +    char *__p = (char *)(unsigned long)(p);     \
>> > +    (__p >= _srodata) && (__p < _erodata);      \
>> 
>> Obviously the above calls for adjustments here, too.
> 
> sorry I am not sure what you mean

Should be 'const char *' at least in the declaration of 'p' (but perhaps
also in the cast).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel