Re: [Xen-devel] [PATCH] Qemu MSI Cleaning Up

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 6 Dec 2011, Jan Beulich wrote:
> >>> On 02.12.11 at 13:40, Stefano Stabellini 
> >>> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > The two mapping and unmapping big chuncks of code looks very similar
> > apart from the DPCI_ADD_MAPPING/DPCI_REMOVE_MAPPING parameter.
> > Could they be refactored into a single function called 
> > "change_msix_mappings"?
> > This is more or less what I have in mind:
> > 
> > change_msix_mappings(assigned_device, DPCI_REMOVE_MAPPING);
> > 
> > update mmio_base_addr
> > 
> > change_msix_mappings(assigned_device, DPCI_ADD_MAPPING);
> 
> Please see below/attached for the outcome. Without MSI-X capable
> devices to pass through, I have to rely on others to do some testing
> on this.

It looks fine.
Haitao, are you happy with the new patch?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel