Re: [Xen-devel] [PATCH] netback: remove redundant assignment

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2011-12-06 at 10:08 +0000, Wei Liu wrote:
> New value for netbk->mmap_pages[pending_idx] is assigned in
> xen_netbk_alloc_page(), no need for a second assignment which
> exposes internal to the outside world.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  drivers/net/xen-netback/netback.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/xen-netback/netback.c 
> b/drivers/net/xen-netback/netback.c
> index 15e332d..3ecb5aa 100644
> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -940,8 +940,6 @@ static struct gnttab_copy *xen_netbk_get_requests(struct 
> xen_netbk *netbk,
>               if (!page)
>                       return NULL;
>  
> -             netbk->mmap_pages[pending_idx] = page;
> -
>               gop->source.u.ref = txp->gref;
>               gop->source.domid = vif->domid;
>               gop->source.offset = txp->offset;
> @@ -1336,8 +1334,6 @@ static unsigned xen_netbk_tx_build_gops(struct 
> xen_netbk *netbk)
>                       continue;
>               }
>  
> -             netbk->mmap_pages[pending_idx] = page;
> -
>               gop->source.u.ref = txreq.gref;
>               gop->source.domid = vif->domid;
>               gop->source.offset = txreq.offset;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel