Re: [Xen-devel] [PATCH] tools/firmware: remove "_PS0/3" Method

["Hao, Xudong" <xudong.hao@xxxxxxxxx>]

(Resend patch because the previous patch loss to remove one line code.)

tools/firmware: remove "_PS0/3" Method

Do not expose the ACPI power management "_PS0/3" Method to guest firmware. 
According to section 3.4 of the APCI specification 4.0, PCI device control the 
device power through its own specification but not through APCI.

Qemu pushes "_PS0/3" to guest will cause a mess between ACPI PM and PCI PM as a 
result of incorrect ACPI table shipped with the guest BIOS, it may cause a 
failure of PCI device PM state transition(from PCI_UNKNOWN to PCI_D0).

Signed-off-by: Xudong Hao <xudong.hao@xxxxxxxxx>
Signed-off-by: Haitao Shan <haitao.shan@xxxxxxxxx>

diff -r df7cec2c6c03 tools/firmware/hvmloader/acpi/mk_dsdt.c
--- a/tools/firmware/hvmloader/acpi/mk_dsdt.c   Tue Nov 29 13:30:39 2011 -0500
+++ b/tools/firmware/hvmloader/acpi/mk_dsdt.c   Fri Dec 02 21:56:14 2011 +0800
@@ -323,8 +323,6 @@
      * the ACPI event:
      *  _EJ0: eject a device
      *  _STA: return a device's status, e.g. enabled or removed
-     * Other methods are optional: 
-     *  _PS0/3: put them here for debug purpose
      * 
      * Eject button would generate a general-purpose event, then the
      * control method for this event uses Notify() to inform OSPM which
@@ -344,14 +342,6 @@
             stmt("Name", "_ADR, 0x%08x", ((slot & ~7) << 13) | (slot & 7));
             /* _SUN == dev */
             stmt("Name", "_SUN, 0x%08x", slot >> 3);
-            push_block("Method", "_PS0, 0");
-            stmt("Store", "0x%02x, \\_GPE.DPT1", slot);
-            stmt("Store", "0x80, \\_GPE.DPT2");
-            pop_block();
-            push_block("Method", "_PS3, 0");
-            stmt("Store", "0x%02x, \\_GPE.DPT1", slot);
-            stmt("Store", "0x83, \\_GPE.DPT2");
-            pop_block();
             push_block("Method", "_EJ0, 1");
             stmt("Store", "0x%02x, \\_GPE.DPT1", slot);
             stmt("Store", "0x88, \\_GPE.DPT2");



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

Thanks,
-Xudong


> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Hao, Xudong
> Sent: Friday, December 02, 2011 4:39 PM
> To: xen-devel@xxxxxxxxxxxxxxxxxxx
> Cc: Tian, Kevin; Keir Fraser; Shan, Haitao
> Subject: [Xen-devel] [PATCH] tools/firmware: remove "_PS0/3" Method
> 
> tools/firmware: remove "_PS0/3" Method
> 
> Do not expose the ACPI power management "_PS0/3" Method to guest
> firmware. According to section 3.4 of the APCI specification 4.0, PCI device
> control the device power through its own specification but not through APCI.
> 
> Qemu pushes "_PS0/3" to guest will cause a mess between ACPI PM and PCI
> PM as a result of incorrect ACPI table shipped with the guest BIOS, it may
> cause a failure of PCI device PM state transition(from PCI_UNKNOWN to
> PCI_D0).
> 
> Signed-off-by: Xudong Hao <xudong.hao@xxxxxxxxx>
> Signed-off-by: Haitao Shan <haitao.shan@xxxxxxxxx>
> 
> diff -r df7cec2c6c03 tools/firmware/hvmloader/acpi/mk_dsdt.c
> --- a/tools/firmware/hvmloader/acpi/mk_dsdt.c Tue Nov 29 13:30:39 2011
> -0500
> +++ b/tools/firmware/hvmloader/acpi/mk_dsdt.c Wed Nov 30 15:08:20 2011
> +0800
> @@ -323,8 +323,6 @@
>       * the ACPI event:
>       *  _EJ0: eject a device
>       *  _STA: return a device's status, e.g. enabled or removed
> -     * Other methods are optional:
> -     *  _PS0/3: put them here for debug purpose
>       *
>       * Eject button would generate a general-purpose event, then the
>       * control method for this event uses Notify() to inform OSPM which @@
> -344,13 +342,6 @@
>              stmt("Name", "_ADR, 0x%08x", ((slot & ~7) << 13) | (slot & 7));
>              /* _SUN == dev */
>              stmt("Name", "_SUN, 0x%08x", slot >> 3);
> -            push_block("Method", "_PS0, 0");
> -            stmt("Store", "0x%02x, \\_GPE.DPT1", slot);
> -            stmt("Store", "0x80, \\_GPE.DPT2");
> -            pop_block();
> -            push_block("Method", "_PS3, 0");
> -            stmt("Store", "0x%02x, \\_GPE.DPT1", slot);
> -            stmt("Store", "0x83, \\_GPE.DPT2");
>              pop_block();
>              push_block("Method", "_EJ0, 1");
>              stmt("Store", "0x%02x, \\_GPE.DPT1", slot)
> 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Attachment: remove_PS0_method.patch
Description: remove_PS0_method.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel