Re: [Xen-devel] Compile error with Ubuntu 11.10

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2011-11-30 at 21:19 +0000, Adda Rathbone wrote:
> Hi,
> compilation of xen-unstable with a fresh Ubuntu 11.10 x86_64 fails
> with following error:
> 
> cc1: warnings being treated as errors
> libxl_create.c: In function âstore_libxl_entryâ:
> libxl_create.c:465: error: format not a string literal and no format 
> arguments

Looks like Ubuntu has enabled -Wformat-nonliteral by default

I expect that this needs to change to be
    return libxl__xs_write(gc, XBT_NULL, path, "%s", libxl__strdup(gc,
       libxl_device_model_version_to_string(dm_info->device_model_version)));
(note the additional "%s",)

Can you try that?

The other alternative would be to add -Wnoformat-nonliteral I guess.

It's also not obvious what the strdup is for there.

Ian.


> 
> Steps to reproduce:
> 
> - Install Ubuntu 11.10
> (http://www.ubuntu.com/start-download?distro=desktop&bits=64&release=latest)
> - sudo apt-get install mercurial libsdl-dev pciutils-dev ncurses-dev
> uuid-dev gettext libyajl-dev flex zlib1g-dev libssl-dev xorg-dev bcc
> bin86 iasl libc6-dev-i386 patch git
> - hg clone http://xenbits.xensource.com/xen-unstable.hg
> - cd xen-unstable.hg/tools
> - make
> 
> Adda



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel