Re: [Xen-devel] [PATCH 1/3] qemu-xen: Change prototype for pt_pci_host_read/write

[Jean Guyader <jean.guyader@xxxxxxxxxxxxx>]

On 25/11 09:29, Jean Guyader wrote:
> On 24/11 06:56, Ian Jackson wrote:
> > Jean Guyader writes ("[Xen-devel] [PATCH 1/3] qemu-xen: Change prototype 
> > for pt_pci_host_read/write"):
> > > pt_pci_host_read/write now takes a struct pci_dev*.
> > 
> > Why ?
> > 
> > Ian.
> 
> I found it more elegant that having to do thing like that:
>         val = pt_pci_host_read(0, PCI_SLOT(pci_dev->devfn),
>                 0, config_addr, len);
> pci_dev is already of the right type.
> 
> With the old approach you would give a B:D:F to pt_pci_host_read
> then the function will call to libpci to get a pci_dev from that
> to do the config space access. In pretty much all the cases we
> already have a pci_dev, so I figured that we should be using it
> directly.
> 

Hi Ian,

Any thought about this serie?

Jean

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel