[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 2/4] docs/html/: Annotations for two hypercalls
On Tue, 2011-11-29 at 15:29 +0000, Ian Jackson wrote: > Ian Campbell writes ("Re: [Xen-devel] [PATCH 2/4] docs/html/: Annotations for > two hypercalls"): > > On Tue, 2011-11-29 at 15:01 +0000, Ian Jackson wrote: > > > This exercise revealed a couple of infelicities: > > > * In the actual source code, do_mmu_update is defined to return an int > > > and do_set_trap_table a long. However both functions return either > > > -Efoo (on error) or 0 for success. > > > > Should that be fixed or would that do more harm than good? > > I wasn't sure whether I should go through all the hypercalls checking > and perhaps fixing up their return values. I'd definitely wait for Keir's OK before spending any time on it. Even then it's likely to be a lot of fiddly work to convince yourself the change is correct/safe and not an ABI wart we are stuck with... > > > Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> > > Thanks, > Ian. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |