[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4 of 6] Add sprintf() to hvmloader



On 11/29/11 12:04, Paul Durrant wrote:
-----Original Message-----
From: Christoph Egger [mailto:Christoph.Egger@xxxxxxx]
Sent: 29 November 2011 11:02
To: Paul Durrant
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH 4 of 6] Add sprintf() to hvmloader

On 11/29/11 11:53, Paul Durrant wrote:
# HG changeset patch
# User Paul Durrant<paul.durrant@xxxxxxxxxx>  # Date 1322563734 0 #
Node ID e9997777ab6d629b97a8b8f020c18f40c4cf3aa0
# Parent  58cdfa17fb8801ab0a9e8133e0ec2ad47a426f5d
Add sprintf() to hvmloader.

For security reasons I prefer snprintf().


Given the limited usecase, I decided it wasn't worth it but
> I can tag on a extra patch to make the conversion if you want me to.

Yes, please. This makes new code less prone to buffer overflows
in general.

Christoph

--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.