Re: [Xen-devel] [PATCH 2/2] qemu-dm: open char devices "file:..." with O_APPEND

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2011-11-28 at 12:30 +0000, Ian Jackson wrote:
> The "file:..." character open method is used by serial and parallel
> ports, to divert the output to a file (and these devices never produce
> any input).  This is like a logfile, and so should be opened for
> append.
> 
> In qemu-xen-unstable, this is used only for the qemu stderr by libxl.

Do we need a similar patch for qemu upstream?

> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> 
> diff --git a/qemu-char.c b/qemu-char.c
> index 35e428d..324ed16 100644
> --- a/qemu-char.c
> +++ b/qemu-char.c
> @@ -588,7 +588,7 @@ static CharDriverState *qemu_chr_open_file_out(const char 
> *file_out)
>  {
>      int fd_out;
>  
> -    TFR(fd_out = open(file_out, O_WRONLY | O_TRUNC | O_CREAT | O_BINARY, 
> 0666));
> +    TFR(fd_out = open(file_out, O_WRONLY | O_TRUNC | O_CREAT | O_BINARY | 
> O_APPEND, 0666));
>      if (fd_out < 0)
>          return NULL;
>      return qemu_chr_open_fd(-1, fd_out);
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel