[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-devel] [PATCH 01/13] libxl: Make libxl__xs_* more const-correct
Paths and values which are not modified by these functions should be declared as "const char *" not "char *". Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> --- tools/libxl/libxl_internal.h | 9 +++++---- tools/libxl/libxl_xshelp.c | 9 +++++---- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h index 84da6b1..bfc74c9 100644 --- a/tools/libxl/libxl_internal.h +++ b/tools/libxl/libxl_internal.h @@ -172,18 +172,19 @@ _hidden char *libxl__dirname(libxl__gc *gc, const char *s); _hidden char **libxl__xs_kvs_of_flexarray(libxl__gc *gc, flexarray_t *array, int length); _hidden int libxl__xs_writev(libxl__gc *gc, xs_transaction_t t, - char *dir, char **kvs); + const char *dir, char **kvs); _hidden int libxl__xs_write(libxl__gc *gc, xs_transaction_t t, - char *path, const char *fmt, ...) PRINTF_ATTRIBUTE(4, 5); + const char *path, const char *fmt, ...) PRINTF_ATTRIBUTE(4, 5); /* Each fn returns 0 on success. * On error: returns -1, sets errno (no logging) */ _hidden char *libxl__xs_get_dompath(libxl__gc *gc, uint32_t domid); /* On error: logs, returns NULL, sets errno. */ -_hidden char *libxl__xs_read(libxl__gc *gc, xs_transaction_t t, char *path); +_hidden char *libxl__xs_read(libxl__gc *gc, xs_transaction_t t, + const char *path); _hidden char **libxl__xs_directory(libxl__gc *gc, xs_transaction_t t, - char *path, unsigned int *nb); + const char *path, unsigned int *nb); /* On error: returns NULL, sets errno (no logging) */ _hidden char *libxl__xs_libxl_path(libxl__gc *gc, uint32_t domid); diff --git a/tools/libxl/libxl_xshelp.c b/tools/libxl/libxl_xshelp.c index 4b09be3..bc4e7e4 100644 --- a/tools/libxl/libxl_xshelp.c +++ b/tools/libxl/libxl_xshelp.c @@ -49,7 +49,7 @@ char **libxl__xs_kvs_of_flexarray(libxl__gc *gc, flexarray_t *array, int length) } int libxl__xs_writev(libxl__gc *gc, xs_transaction_t t, - char *dir, char *kvs[]) + const char *dir, char *kvs[]) { libxl_ctx *ctx = libxl__gc_owner(gc); char *path; @@ -69,7 +69,7 @@ int libxl__xs_writev(libxl__gc *gc, xs_transaction_t t, } int libxl__xs_write(libxl__gc *gc, xs_transaction_t t, - char *path, const char *fmt, ...) + const char *path, const char *fmt, ...) { libxl_ctx *ctx = libxl__gc_owner(gc); char *s; @@ -87,7 +87,7 @@ int libxl__xs_write(libxl__gc *gc, xs_transaction_t t, return 0; } -char * libxl__xs_read(libxl__gc *gc, xs_transaction_t t, char *path) +char * libxl__xs_read(libxl__gc *gc, xs_transaction_t t, const char *path) { libxl_ctx *ctx = libxl__gc_owner(gc); char *ptr; @@ -113,7 +113,8 @@ char *libxl__xs_get_dompath(libxl__gc *gc, uint32_t domid) return s; } -char **libxl__xs_directory(libxl__gc *gc, xs_transaction_t t, char *path, unsigned int *nb) +char **libxl__xs_directory(libxl__gc *gc, xs_transaction_t t, + const char *path, unsigned int *nb) { libxl_ctx *ctx = libxl__gc_owner(gc); char **ret = NULL; -- 1.7.2.5 _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |