Re: [Xen-devel] [PATCH 2/5] xen: Add privcmd device driver

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sun, 2011-11-27 at 22:07 +0000, Bastian Blank wrote:
> @@ -84,7 +85,7 @@ static int xenfs_fill_super(struct super_block *sb,
> void *data, int silent)
>                 [1] = {},
>                 { "xenbus", &xenbus_file_ops, S_IRUSR|S_IWUSR },
>                 { "capabilities", &capabilities_file_ops, S_IRUGO },
> -               { "privcmd", &privcmd_file_ops, S_IRUSR|S_IWUSR },
> +               { "privcmd", &xen_privcmd_fops, S_IRUSR|S_IWUSR },
>                 {""},
>         };
>         int rc; 

I wonder if we could do something dumb like make /proc/xen/privcmd by a
symlink to /dev/xen/privcmd instead of introducing this cross module
dependency?

The main reason would be to avoid the select since selecting on user
visible symbols is a recipe for confusion and is generally advised
against.

Perhaps the xen-privcmd.ko should simply call a newly introduced
xenfs_register()? This would be a nop if CONFIG_XENFS=n and therefore
the select would not be necessary. If COFIG_XENFS=[my] then modprobe
will do the right thing.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel