Re: [Xen-devel] [xen-unstable test] 10135: regressions - FAIL

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2011-11-28 at 13:38 +0000, Ian Campbell wrote:
> On Mon, 2011-11-28 at 11:58 +0000, Ian Jackson wrote:
> > xen.org writes ("[xen-unstable test] 10135: regressions - FAIL"):
> > > flight 10135 xen-unstable real [real]
> > > http://www.chiark.greenend.org.uk/~xensrcts/logs/10135/
> > > 
> > > Regressions :-(
> > > 
> > > Tests which did not succeed and are blocking:
> > >  test-amd64-i386-rhel6hvm-intel  7 redhat-install       fail REGR. vs. 
> > > 9956
> > 
> > My bisector wasn't able to finger an exact changeset due to a blocking
> > bug in the vicinity, but:
> > 
> >   pass      24183:53bec838bb08  Merge
> >   blocked   24184:4ecd3615e726  tools: use system installed libaio by 
> > default.
> >   blocked   24185:f88c745575bb  docs: remove some fatally out of date ...
> >   fail      24186:7aa5838499d1  tools: use system libaio for blktap1 as 
> > well.
> > 
> > Here the "system installed libaio" is that from Debian squeeze.
> 
> This is really weird since nothing in the failings tests even exercises
> this stuff. Only blktap (1 and 2) uses aio and the the tests don't use
> it and neither does qemu-dm which is the only other thing I can think
> of.

Turns out the test system is using the 2.6.32 kernel from xen.git and
hence is using tapdisk2 for the guest cdrom drive.

>  I'm setting up a repro to see if I can figure out what is going
> wrong.

I didn't get as far a reproing but I realised that the issue was that
libaio was not installed on the target and so tapdisk was failing to run
but error handling was broken so we didn't notice apart from some
messages deep in the logs. The following fixes the error handling:

8>-------------------------------------------------------------

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1322493402 0
# Node ID 35883c0b285c8dfce341bdd04deda53ab6db03cf
# Parent  f688f1c8205f90bbfbd6900ccd410382c676b47f
libxl: propagate error from tap_ctl_spawn.

Failure here means that a disk will not be correctly setup. I briefly
scanned tools/blktap2/control.c for other goto constructs which did not
set their err variable but didn't see any others.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r f688f1c8205f -r 35883c0b285c tools/blktap2/control/tap-ctl-create.c
--- a/tools/blktap2/control/tap-ctl-create.c    Mon Nov 28 12:59:15 2011 +0000
+++ b/tools/blktap2/control/tap-ctl-create.c    Mon Nov 28 15:16:42 2011 +0000
@@ -44,8 +44,10 @@ tap_ctl_create(const char *params, char 
                return err;
 
        id = tap_ctl_spawn();
-       if (id < 0)
+       if (id < 0) {
+               err = id;
                goto destroy;
+       }
 
        err = tap_ctl_attach(id, minor);
        if (err)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel