[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Unaligned writes on the kexec path



Hello,

In c/s 7493bb48d89f, you change the internals of kexec_crash_save_info()
to reduce unaligned writes, but pass the resulting pointer back to
machine_crash_shutdown() which performs writes on the possibly unaligned
data structure.  There are also plenty of other writes on the kexec path
which are possibly or certainly unaligned.

What is the reason for wanting to reduce unaligned writes?

Would a better solution be to just ensure that the crash note itself is
properly aligned?

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.