Re: [Xen-devel] [PATCH 4 of 5] Add code to track the address of the VM generation id buffer across a

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: Tim Deegan [mailto:tim@xxxxxxx]
> Sent: 28 November 2011 12:33
> To: Paul Durrant
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [PATCH 4 of 5] Add code to track the
> address of the VM generation id buffer across a
> 
> At 12:15 +0000 on 28 Nov (1322482536), Paul Durrant wrote:
> > --- a/xen/include/public/hvm/params.h       Mon Nov 28 12:14:48 2011
> +0000
> > +++ b/xen/include/public/hvm/params.h       Mon Nov 28 12:14:49 2011
> +0000
> > @@ -142,6 +142,9 @@
> >  /* Boolean: Enable nestedhvm (hvm only) */
> >  #define HVM_PARAM_NESTEDHVM    24
> >
> > -#define HVM_NR_PARAMS          27
> > +/* Address of VM generation id buffer */ #define
> > +HVM_PARAM_VM_GENERATION_ID_ADDR 27
> > +
> > +#define HVM_NR_PARAMS          28
> >
> >  #endif /* __XEN_PUBLIC_HVM_PARAMS_H__ */
> 
> Since the hypervisor doesn't use this value, I don't think this is
> the right place for it to live.  Tools-only VM metadata should
> probably go in xenstore or in the toolstacks' own datastructures.
> 

Yes, I was a little unsure about that. Is there any precedent for getting 
information from hvmloader out to the tools? Writing guest physical addresses 
into xenstore seems like the wrong thing to but apart from HVM params or the 
shared hvm info page, I couldn't think of another way apart from putting the VM 
generation id in a static well-known place.

  Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel