[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] Fix save/restore for HVM domains with viridian=1
Yes, I forgot about #GP. Windows 7 unfortunately handles and but doesn't complain. I'll ditch the logging. Paul > -----Original Message----- > From: Keir Fraser [mailto:keir.xen@xxxxxxxxx] > Sent: 25 November 2011 15:18 > To: Tim (Xen.org); Paul Durrant > Cc: xen-devel@xxxxxxxxxxxxxxxxxxx > Subject: Re: [Xen-devel] [PATCH] Fix save/restore for HVM domains > with viridian=1 > > On 25/11/2011 15:00, "Tim Deegan" <tim@xxxxxxx> wrote: > > >> - if ( !is_viridian_domain(d) ) > >> + if ( !is_viridian_domain(d) ) { > >> + gdprintk(XENLOG_WARNING, "%s: %d not a viridian > domain\n", __func__, > >> + d->domain_id); > > > > This should probably be rate-limited; a confused domain could > cause a > > _lot_ of these. Might we want to pause/kill the domain as well, > or > > inject a fault? > > We do XENLOG_WARNING logging on various paths that silently fail > (e.g., weird writes to the VIOAPIC). We should probably just #GP, > that will silence the guest pretty quickly. I can make that change. > > -- Keir > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |